Open
Conversation
rumachan
requested changes
Feb 2, 2026
Contributor
rumachan
left a comment
rumachan
left a comment
There was a problem hiding this comment.
Looks good except for install time of new camera, 2026-01-28T22:20:01Z, needs to be 22:19:59Z, so 1 second before first image.
I thought we might be able to include the 100 deg azimuth, but when I looked at a map its not clear that is correct, so I agree to not include.
The README.md doesn't say what to do for no data. Using zeros implies information we don't have. Can you check if checks are passed for null fields for dip,azimuth,height? Isn't that a better option?
Contributor
Author
|
I would prefer to leave the zeroes as is and if we want to move to an empty field convention we should do it for all sites. I have corrected the timing - thanks for that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.